Messages in this thread | | | Date | Thu, 3 Nov 2022 23:45:26 +0900 | From | Greg KH <> | Subject | Re: [PATCH v3] usb: cdnsp: Fix wrong transmission direction of EP0 |
| |
On Tue, Nov 01, 2022 at 10:43:21AM +0100, Greg KH wrote: > On Tue, Nov 01, 2022 at 02:17:30PM +0800, Jing Leng wrote: > > EP0 transfer is bi-directional, but in the cdnsp gadget, the > > transmission direction of EP0 is not changed after it is > > initialized to IN, so the OUT data from EP0 received by the host > > is invalid. > > > > The value of ep0_expect_in will change according to the value of > > bRequestType in the SETUP transaction of control transfer, so we > > can use it as the transmission direction of EP0. > > > > Signed-off-by: Jing Leng <jleng@ambarella.com> > > --- > > ChangeLog v2->v3: > > - Repair my email address. > > Yes, it works, and it's validated! > > Nice job, thanks. I'll let the cdns3 maintainer review it first, but > just wanted to say thanks for fixing this up, it makes my life a lot > easier when accepting patches.
Oops, I missed that email footer, sorry. That is NOT compatible with Linux kernel development, and as per the recommendation from my legal people, I have to go revert that change as we can't take it as-is because it might have been sent out incorrectly as it was stated to be "Proprietary and/or Confidential Information" which is not allowed in the Linux kernel.
thanks,
greg k-h
| |