Messages in this thread | | | Date | Thu, 3 Nov 2022 14:39:21 +0100 | Subject | Re: [PATCH 2/2] KVM: x86: Fix a typo about the usage of kvcalloc() | From | Paolo Bonzini <> |
| |
On 11/3/22 02:17, Liao Chang wrote: > Swap the 1st and 2nd arguments to be consistent with the usage of > kvcalloc(). > > Fixes: c9b8fecddb5b ("KVM: use kvcalloc for array allocations") > Signed-off-by: Liao Chang<liaochang1@huawei.com> > --- > arch/x86/kvm/cpuid.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/x86/kvm/cpuid.c b/arch/x86/kvm/cpuid.c > index 7065462378e2..b33c18b142c2 100644 > --- a/arch/x86/kvm/cpuid.c > +++ b/arch/x86/kvm/cpuid.c > @@ -1331,7 +1331,7 @@ int kvm_dev_ioctl_get_cpuid(struct kvm_cpuid2 *cpuid, > if (sanity_check_entries(entries, cpuid->nent, type)) > return -EINVAL; > > - array.entries = kvcalloc(sizeof(struct kvm_cpuid_entry2), cpuid->nent, GFP_KERNEL); > + array.entries = kvcalloc(cpuid->nent, sizeof(struct kvm_cpuid_entry2), GFP_KERNEL); > if (!array.entries) > return -ENOMEM; >
It doesn't make any difference, but scripts/checkpatch.pl checks it so let's fix the sole occurrence in KVM.
However, please send a patch to scripts/checkpatch.pl to include calloc(), kvmalloc_array and kvcalloc() in the matched functions:
# check for alloc argument mismatch if ($line =~ /\b((?:devm_)?(?:kcalloc|kmalloc_array))\s*\(\s*sizeof\b/) { WARN("ALLOC_ARRAY_ARGS", "$1 uses number as first arg, sizeof is generally wrong\n" . $herecurr); }
Paolo
| |