| From | Cornelia Huck <> | Subject | Re: [PATCH 04/44] KVM: Teardown VFIO ops earlier in kvm_exit() | Date | Thu, 03 Nov 2022 13:46:28 +0100 |
| |
On Wed, Nov 02 2022, Sean Christopherson <seanjc@google.com> wrote:
> Move the call to kvm_vfio_ops_exit() further up kvm_exit() to try and > bring some amount of symmetry to the setup order in kvm_init(), and more > importantly so that the arch hooks are invoked dead last by kvm_exit(). > This will allow arch code to move away from the arch hooks without any > change in ordering between arch code and common code in kvm_exit(). > > That kvm_vfio_ops_exit() is called last appears to be 100% arbitrary. It > was bolted on after the fact by commit 571ee1b68598 ("kvm: vfio: fix > unregister kvm_device_ops of vfio"). The nullified kvm_device_ops_table > is also local to kvm_main.c and is used only when there are active VMs, > so unless arch code is doing something truly bizarre, nullifying the > table earlier in kvm_exit() is little more than a nop. > > Signed-off-by: Sean Christopherson <seanjc@google.com> > --- > virt/kvm/kvm_main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)
Looks safe to me.
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
|