Messages in this thread | | | From | <> | Subject | RE: [PATCH v6 1/2] dt-bindings: it6505: add properties to restrict output bandwidth | Date | Thu, 3 Nov 2022 08:27:58 +0000 |
| |
hi
-----Original Message----- From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Sent: Thursday, November 3, 2022 12:34 AM To: Allen Chen (陳柏宇) <allen.chen@ite.com.tw> Cc: treapking@chromium.org; Jau-Chih Tseng (曾昭智) <Jau-Chih.Tseng@ite.com.tw>; Hermes Wu (吳佳宏) <Hermes.Wu@ite.com.tw>; Kenneth Hung (洪家倫) <Kenneth.Hung@ite.com.tw>; andrzej.hajda@intel.com; narmstrong@baylibre.com; robert.foss@linaro.org; Laurent.pinchart@ideasonboard.com; jonas@kwiboo.se; jernej.skrabec@gmail.com; airlied@linux.ie; daniel@ffwll.ch; robh+dt@kernel.org; krzysztof.kozlowski+dt@linaro.org; dri-devel@lists.freedesktop.org; devicetree@vger.kernel.org; linux-kernel@vger.kernel.org Subject: Re: [PATCH v6 1/2] dt-bindings: it6505: add properties to restrict output bandwidth
On 02/11/2022 02:54, allen.chen@ite.com.tw wrote: > On 26/10/2022 23:01, allen wrote: >> From: allen chen <allen.chen@ite.com.tw> >> >> Add properties to restrict dp output data-lanes and clock. > > This is a friendly reminder during the review process. > > It seems my previous comments were not fully addressed. Maybe my feedback got lost between the quotes, maybe you just forgot to apply it. > Please go back to the previous discussion and either implement all requested changes or keep discussing them. > > Thank you. > > ==> I am sorry I didn't find the missing advice you said. Could you explain it again? > > Rob asked - Commit msg should explain reason for breaking users.
And where is the reason? I saw only one sentence "Add properties to restrict dp output data-lanes and clock." ==> I will add the commit msg in v7. Thanks for the suggestion.
Best regards, Krzysztof
| |