lkml.org 
[lkml]   [2022]   [Nov]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH] remoteproc: imx_rproc: correct i.MX93 DRAM mapping
Date
> Subject: Re: [PATCH] remoteproc: imx_rproc: correct i.MX93 DRAM mapping
>
> On Wed, 2 Nov 2022 at 05:12, Peng Fan (OSS) <peng.fan@oss.nxp.com>
> wrote:
> >
> > From: Peng Fan <peng.fan@nxp.com>
> >
> > According to updated reference mannual, the M33 DRAM view of
> > 0x[C,D]0000000 maps to A55 0xC0000000, so correct it.
> >
> > Fixes: 9222fabf0e39 ("remoteproc: imx_rproc: Support i.MX93")
> > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > ---
> > drivers/remoteproc/imx_rproc.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/remoteproc/imx_rproc.c
> > b/drivers/remoteproc/imx_rproc.c index 2c471e46f4ca..9fc978e0393c
> > 100644
> > --- a/drivers/remoteproc/imx_rproc.c
> > +++ b/drivers/remoteproc/imx_rproc.c
> > @@ -134,8 +134,8 @@ static const struct imx_rproc_att
> imx_rproc_att_imx93[] = {
> > { 0x80000000, 0x80000000, 0x10000000, 0 },
> > { 0x90000000, 0x80000000, 0x10000000, 0 },
> >
> > - { 0xC0000000, 0xa0000000, 0x10000000, 0 },
> > - { 0xD0000000, 0xa0000000, 0x10000000, 0 },
> > + { 0xC0000000, 0xC0000000, 0x10000000, 0 },
> > + { 0xD0000000, 0xC0000000, 0x10000000, 0 },
>
> But how did this work before? Were some SoC released with the old
> mapping?
The current m33 firmware release with Linux SDK only has
TCM version, so I not have image to test the DDR mapping.

Initially we got the information that M33 mapping of DRAM.
DRAM (offset 0 MB) DRAM 80000000
DRAM (offset 256 MB) DRAM A0000000
DRAM (offset 512 MB) DRAM C0000000

However the information is wrong after we check more,
there is an 256MB hole, 0MB [0x80000000, 0x8fffffff],
512MB [0xa0000000, 0xafffffff],
1024MB [0xc0000000, 0xcfffffff]

I use JTAG to confirm it.

Thanks,
Peng.
>
> > };
> >
> > static const struct imx_rproc_att imx_rproc_att_imx8qm[] = {
> > --
> > 2.37.1
> >
\
 
 \ /
  Last update: 2022-11-03 07:12    [W:0.082 / U:1.092 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site