lkml.org 
[lkml]   [2022]   [Nov]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v6 1/3] dt-bindings: hwmon: fan: Add fan binding to schema
From
Hi Krzysztof,

On 29-11-2022 01:38 pm, Krzysztof Kozlowski wrote:
> On 16/11/2022 22:36, Naresh Solanki wrote:
>> Add common fan properties bindings to a schema.
>>
>> Bindings for fan controllers can reference the common schema for the
>> fan
>>
>> child nodes:
>>
>> patternProperties:
>> "^fan@[0-2]":
>> type: object
>> $ref: fan-common.yaml#
>>
>> Signed-off-by: Naresh Solanki <Naresh.Solanki@9elements.com>
>> ---
>> .../devicetree/bindings/hwmon/fan-common.yaml | 42 +++++++++++++++++++
>> 1 file changed, 42 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/hwmon/fan-common.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/hwmon/fan-common.yaml b/Documentation/devicetree/bindings/hwmon/fan-common.yaml
>> new file mode 100644
>> index 000000000000..1954882eed77
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/hwmon/fan-common.yaml
>> @@ -0,0 +1,42 @@
>> +# SPDX-License-Identifier: GPL-2.0-or-later OR BSD-2-Clause
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/hwmon/fan-common.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Common fan properties
>
> If there is going to be resend - capitalize title, so:
>
> Common Fan Properties
>
Sure
>> +
>> +maintainers:
>> + - Naresh Solanki <naresh.solanki@9elements.com>
>> +
>> +properties:
>> + max-rpm:
>> + description:
>> + Max RPM supported by fan.
>> + $ref: /schemas/types.yaml#/definitions/uint32
>> +
>> + pulses-per-revolution:
>> + description:
>> + The number of pulse from fan sensor per revolution.
>> + $ref: /schemas/types.yaml#/definitions/uint32
>> +
>> + target-rpm:
>> + description:
>> + Target RPM the fan should be configured during driver probe.
>> + $ref: /schemas/types.yaml#/definitions/uint32
>> +
>> + pwms:
>> + description:
>> + PWM provider.
>
> Isn't this object? If so, maybe:
> type: object
With make dt_binding_check, I'm getting error for this.
Looking at other available examples in documentation, type object is not
used.

Example:
pwms:
maxItems: 1

One pwm per fan.
>
>
>
> Best regards,
> Krzysztof
>
Regards,
Naresh

\
 
 \ /
  Last update: 2022-11-29 16:46    [W:0.074 / U:0.084 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site