lkml.org 
[lkml]   [2022]   [Nov]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] ieee802154: cc2520: Fix error return code in cc2520_hw_init()
From
Hello.

On 20.11.22 08:50, Ziyang Xuan wrote:
> In cc2520_hw_init(), if oscillator start failed, the error code
> should be returned.
>
> Fixes: 0da6bc8cc341 ("ieee802154: cc2520: adds driver for TI CC2520 radio")
> Signed-off-by: Ziyang Xuan <william.xuanziyang@huawei.com>
> ---
> drivers/net/ieee802154/cc2520.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ieee802154/cc2520.c b/drivers/net/ieee802154/cc2520.c
> index c69b87d3837d..edc769daad07 100644
> --- a/drivers/net/ieee802154/cc2520.c
> +++ b/drivers/net/ieee802154/cc2520.c
> @@ -970,7 +970,7 @@ static int cc2520_hw_init(struct cc2520_private *priv)
>
> if (timeout-- <= 0) {
> dev_err(&priv->spi->dev, "oscillator start failed!\n");
> - return ret;
> + return -ETIMEDOUT;
> }
> udelay(1);
> } while (!(status & CC2520_STATUS_XOSC32M_STABLE));

This patch has been applied to the wpan tree and will be
part of the next pull request to net. Thanks!

regards
Stefan Schmidt

\
 
 \ /
  Last update: 2022-11-29 15:11    [W:0.036 / U:0.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site