lkml.org 
[lkml]   [2022]   [Nov]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: Re: [PATCH 2/4] elevator: replace continue with else-if in elv_iosched_show
> >  	list_for_each_entry(e, &elv_list, list) {
> > - if (e == cur) {
> > + if (e == cur)
> > len += sprintf(name+len, "[%s] ", cur->elevator_name);
> > - continue;
> > - }
> > - if (elv_support_features(q, e))
> > + else if (elv_support_features(q, e))
> > len += sprintf(name+len, "%s ", e->elevator_name);
>
> Looks good. But to make this even more obvious I'd also switch to
> pinting e->elevator_name for the cur case instead of cur.

That's truely better. I'll send a v2 soon.

Thanks!
Jinlong Chen
\
 
 \ /
  Last update: 2022-11-29 11:54    [W:0.853 / U:0.048 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site