lkml.org 
[lkml]   [2022]   [Nov]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v2 1/2] i2c: loongson: add bus driver for the loongson i2c controller
From
On 28/11/2022 15:02, Andy Shevchenko wrote:
> On Mon, Nov 28, 2022 at 09:00:24PM +0800, Yinbo Zhu wrote:
>> This bus driver supports the Loongson i2c hardware controller in the
>> Loongson platforms and supports to use DTS and ACPI framework to
>> register i2c adapter device resources.
>>
>> The Loongson i2c controller supports operating frequencty is 50MHZ
>> and supports the maximum transmission rate is 400kbps.
>
> ...


> Why not using the usual pattern, i.e.
>
> if (!(...))
> return IRQ_NONE;
>
> ?
>
> It seems you ignored some of my comments...
> I stopped here, please check what was given against v1 and try again.

I propose to wait with wasting more time on reviews because you might do
the same work twice:

https://lore.kernel.org/all/822356908305580d601e5b3e424371ed7f220b85.1669359515.git.zhoubinbin@loongson.cn/


Best regards,
Krzysztof

\
 
 \ /
  Last update: 2022-11-28 15:13    [W:0.093 / U:1.608 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site