lkml.org 
[lkml]   [2022]   [Nov]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v3 02/20] iommu/apple-dart: Remove detach_dev callback
    Date
    The IOMMU driver supports default domain, so the detach_dev op will never
    be called. Remove it to avoid dead code.

    Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
    ---
    drivers/iommu/apple-dart.c | 17 -----------------
    1 file changed, 17 deletions(-)

    diff --git a/drivers/iommu/apple-dart.c b/drivers/iommu/apple-dart.c
    index 4f4a323be0d0..6fbe6b275c79 100644
    --- a/drivers/iommu/apple-dart.c
    +++ b/drivers/iommu/apple-dart.c
    @@ -535,22 +535,6 @@ static int apple_dart_attach_dev(struct iommu_domain *domain,
    return ret;
    }

    -static void apple_dart_detach_dev(struct iommu_domain *domain,
    - struct device *dev)
    -{
    - int i;
    - struct apple_dart_stream_map *stream_map;
    - struct apple_dart_master_cfg *cfg = dev_iommu_priv_get(dev);
    - struct apple_dart_domain *dart_domain = to_dart_domain(domain);
    -
    - for_each_stream_map(i, cfg, stream_map)
    - apple_dart_hw_disable_dma(stream_map);
    -
    - if (domain->type == IOMMU_DOMAIN_DMA ||
    - domain->type == IOMMU_DOMAIN_UNMANAGED)
    - apple_dart_domain_remove_streams(dart_domain, cfg);
    -}
    -
    static struct iommu_device *apple_dart_probe_device(struct device *dev)
    {
    struct apple_dart_master_cfg *cfg = dev_iommu_priv_get(dev);
    @@ -780,7 +764,6 @@ static const struct iommu_ops apple_dart_iommu_ops = {
    .owner = THIS_MODULE,
    .default_domain_ops = &(const struct iommu_domain_ops) {
    .attach_dev = apple_dart_attach_dev,
    - .detach_dev = apple_dart_detach_dev,
    .map_pages = apple_dart_map_pages,
    .unmap_pages = apple_dart_unmap_pages,
    .flush_iotlb_all = apple_dart_flush_iotlb_all,
    --
    2.34.1
    \
     
     \ /
      Last update: 2022-11-28 07:55    [W:4.283 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site