Messages in this thread | | | Date | Mon, 28 Nov 2022 13:59:30 +0000 | Subject | Re: [PATCH v3 06/20] iommu/mtk: Remove detach_dev callback | From | Robin Murphy <> |
| |
On 2022-11-28 13:49, Jason Gunthorpe wrote: > On Mon, Nov 28, 2022 at 02:46:34PM +0800, Lu Baolu wrote: >> The IOMMU driver supports default domain, so the detach_dev op will never >> be called. Remove it to avoid dead code. >> >> Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com> >> --- >> drivers/iommu/mtk_iommu.c | 9 --------- >> 1 file changed, 9 deletions(-) > > I listed this driver as not supporting default domains: > > https://lore.kernel.org/linux-iommu/20220516135741.GV1343366@nvidia.com/ > > ? > > Has something changed? Did I get it wrong?
static struct iommu_domain *mtk_iommu_domain_alloc(unsigned type) { struct mtk_iommu_domain *dom;
if (type != IOMMU_DOMAIN_DMA && type != IOMMU_DOMAIN_UNMANAGED) return NULL; ...
This one runs on arm64, so has always supported default domains for iommu-dma to work.
Cheers, Robin.
| |