Messages in this thread | | | Date | Mon, 28 Nov 2022 20:26:38 +0700 | Subject | Re: [PATCH v3 1/2] blk-crypto: Add support for SM4-XTS blk crypto mode | From | Bagas Sanjaya <> |
| |
On 11/25/22 19:16, Tianjia Zhang wrote: > SM4 is a symmetric algorithm widely used in China, and SM4-XTS is also > used to encrypt length-preserving data, these algoritms are mandatory > in many scenarios. This patch enables the use of SM4-XTS algorithm in > block inline encryption, and provides support for fscrypt. >
Please reformulate the patch description in imperative mood instead. Also, take care of wording and punctuation - commas should not be used for continuing distinct sentences/clauses where separating them by a full stop is more appropriate.
That is, the description should be:
``` SM4 is a symmetric cipher algorithm widely used in China. The SM4-XTS variant is used to encrypt length-preserving data.
Enable the algorithm in block inline encryption, as well as enable fscrypt support. ```
Thanks.
-- An old man doll... just what I always wanted! - Clara
| |