Messages in this thread | | | From | Linus Walleij <> | Date | Mon, 28 Nov 2022 21:35:56 +0100 | Subject | Re: [PATCH v8 1/2] gpio: loongson: add gpio driver support |
| |
On Mon, Nov 28, 2022 at 7:43 AM Yinbo Zhu <zhuyinbo@loongson.cn> wrote:
> The Loongson platforms GPIO controller contains 60 GPIO pins in total, > 4 of which are dedicated GPIO pins, and the remaining 56 are reused > with other functions. Each GPIO can set input/output and has the > interrupt capability. > > This driver added support for Loongson GPIO controller and support to > use DTS or ACPI to descibe GPIO device resources. > > Signed-off-by: Jianmin Lv <lvjianmin@loongson.cn> > Signed-off-by: Hongchen Zhang <zhanghongchen@loongson.cn> > Signed-off-by: Liu Peibao <liupeibao@loongson.cn> > Signed-off-by: Juxin Gao <gaojuxin@loongson.cn> > Signed-off-by: Yinbo Zhu <zhuyinbo@loongson.cn>
v8 looks really nice.
> +static int loongson_gpio_to_irq( > + struct gpio_chip *chip, unsigned int offset) > +{ > + struct platform_device *pdev = > + container_of(chip->parent, struct platform_device, dev); > + > + if (offset >= chip->ngpio) > + return -EINVAL;
You forgot to drop this.
With this fixed (and Bartosz requested fix): Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours, Linus Walleij
| |