lkml.org 
[lkml]   [2022]   [Nov]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [patch V3 12/33] PCI/MSI: Add support for per device MSI[X] domains
Date
> From: Thomas Gleixner <tglx@linutronix.de>
> Sent: Friday, November 25, 2022 7:26 AM
> +
> + if (!irq_domain_is_msi_parent(domain)) {
> + /*
> + * For "global" PCI/MSI interrupt domains the associated
> + * msi_domain_info::flags is the authoritive source of
> + * information.
> + */
> + info = domain->host_data;
> + supported = info->flags;
> + } else {
> + /*
> + * For MSI parent domains the supported feature set
> + * is avaliable in the parent ops. This makes checks
> + * possible before actually instantiating the
> + * per device domain because the parent is never
> + * expanding the PCI/MSI functionality.
> + */
> + supported = domain->msi_parent_ops->supported_flags;
> + }

As discussed in v2 it's probably clearer to also mark out that it's always
the direct parent putting restrictions on all existing architectures. That
is why checking direct parent is sufficient here.
\
 
 \ /
  Last update: 2022-11-28 05:47    [W:0.372 / U:1.284 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site