Messages in this thread | | | Date | Mon, 28 Nov 2022 12:06:32 +0800 | From | Herbert Xu <> | Subject | Re: [v2 PATCH 3/9] crypto: aead - Add ctx helpers with DMA alignment |
| |
On Fri, Nov 25, 2022 at 12:24:31PM +0000, Catalin Marinas wrote: > > I wonder, if drivers end up calling this, isn't it easier to do the > alignment in crypto_aead_ctx() directly? There are over 300 callers (not > sure about the padding though, it may need still driver changes unless > we can add it to something like crypto_tfm_alg_alignmask()). Or is the > expectation that not all drivers need a DMA alignment?
I'm only changing the specific drivers that map things from the ctx structures for DMA. So it's not as bad as a simple grep would suggest.
Cheers, -- Email: Herbert Xu <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
| |