| From | "Tian, Kevin" <> | Subject | RE: [patch V3 00/22] genirq, PCI/MSI: Support for per device MSI and PCI/IMS - Part 2 API rework | Date | Mon, 28 Nov 2022 02:33:56 +0000 |
| |
> From: Thomas Gleixner <tglx@linutronix.de> > Sent: Friday, November 25, 2022 7:24 AM > > Changes vs. V2: > > - Rework the xarray storage into per domain storage (Marc) > > @Kevin: I did not pick up your Reviewed-by tag due to these changes. >
The incremental change looks good to me:
Reviewed-by: Kevin Tian <kevin.tian@intel.com>
Just one nit.
> > - xa_for_each_range(xa, idx, desc, ctrl->first + base, ctrl->last + base) { > + xa = &dev->msi.data->__domains[ctrl->domid].store;
Better to have a macro here given multiple references on the store in following lines.
|