lkml.org 
[lkml]   [2022]   [Nov]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [patch V3 00/22] genirq, PCI/MSI: Support for per device MSI and PCI/IMS - Part 2 API rework
Date
> From: Thomas Gleixner <tglx@linutronix.de>
> Sent: Friday, November 25, 2022 7:24 AM
>
> Changes vs. V2:
>
> - Rework the xarray storage into per domain storage (Marc)
>
> @Kevin: I did not pick up your Reviewed-by tag due to these changes.
>

The incremental change looks good to me:

Reviewed-by: Kevin Tian <kevin.tian@intel.com>

Just one nit.

>
> - xa_for_each_range(xa, idx, desc, ctrl->first + base, ctrl->last + base) {
> + xa = &dev->msi.data->__domains[ctrl->domid].store;

Better to have a macro here given multiple references on the store
in following lines.


\
 
 \ /
  Last update: 2022-11-28 03:34    [W:0.176 / U:0.064 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site