Messages in this thread | | | From | "Tian, Kevin" <> | Subject | RE: [patch V2 25/33] PCI/MSI: Provide post-enable dynamic allocation interfaces for MSI-X | Date | Mon, 28 Nov 2022 01:49:44 +0000 |
| |
> From: Thomas Gleixner <tglx@linutronix.de> > Sent: Thursday, November 24, 2022 5:09 PM > >> +void pci_msix_free_irq(struct pci_dev *dev, struct msi_map map) > >> +{ > >> + if (WARN_ON_ONCE(map.index < 0 || map.virq <= 0)) > > > > map.virq cannot be negative. > > Why? Callers can make up whatever they want, no? >
obviously callers can. Read too fast...
Then following check should be fixed too:
+void pci_ims_free_irq(struct pci_dev *dev, struct msi_map map) +{ + if (WARN_ON_ONCE(map.index < 0 || !map.virq)) + return; + msi_domain_free_irqs_range(&dev->dev, MSI_SECONDARY_DOMAIN, map.index, map.index); +}
| |