Messages in this thread | | | Date | Mon, 28 Nov 2022 03:11:53 +0200 | From | Jarkko Sakkinen <> | Subject | Re: [PATCH v3 1/3] certs: log hash value on blacklist error |
| |
"Make blacklisted hash available in klog"
On Fri, Nov 18, 2022 at 05:03:41AM +0100, Thomas Weißschuh wrote: > Without this information these logs are not actionable.
Without blacklisted hash?
> For example on duplicate blacklisted hashes reported by the system > firmware users should be able to report the erroneous hashes to their > system vendors. > > While we are at it use the dedicated format string for ERR_PTR.
Lacks the beef so saying "while we are at it" makes no sense.
> Fixes: 6364d106e041 ("certs: Allow root user to append signed hashes to the blacklist keyring")
Why does this count as a bug?
> Signed-off-by: Thomas Weißschuh <linux@weissschuh.net> > --- > certs/blacklist.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/certs/blacklist.c b/certs/blacklist.c > index 41f10601cc72..6e260c4b6a19 100644 > --- a/certs/blacklist.c > +++ b/certs/blacklist.c > @@ -192,7 +192,7 @@ static int mark_raw_hash_blacklisted(const char *hash) > KEY_ALLOC_NOT_IN_QUOTA | > KEY_ALLOC_BUILT_IN); > if (IS_ERR(key)) { > - pr_err("Problem blacklisting hash (%ld)\n", PTR_ERR(key)); > + pr_err("Problem blacklisting hash %s: %pe\n", hash, key); > return PTR_ERR(key); > } > return 0; > -- > 2.38.1 >
BR, Jarkko
| |