lkml.org 
[lkml]   [2022]   [Nov]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 2/2] ARM: dts: qcom: msm8974: Add OnePlus One
From
On 27/11/2022 19:18, Luca Weiss wrote:
> From: Julian Goldsmith <julian@juliangoldsmith.com>
>
> OnePlus One is a smartphone launched in 2014 and is based on the
> Snapdragon 801 SoC (-AC variant).
>

Thank you for your patch. There is something to discuss/improve.
> +
> +&blsp1_uart2 {
> + status = "okay";
> +};
> +
> +&gcc {
> + compatible = "qcom,gcc-msm8974pro-ac";
> +};
> +
> +&otg {
> + phys = <&usb_hs1_phy>;
> + phy-select = <&tcsr 0xb000 0>;
> + extcon = <&smbb>, <&usb_id>;
> + vbus-supply = <&chg_otg>;
> +
> + hnp-disable;
> + srp-disable;
> + adp-disable;
> +
> + status = "okay";
> +
> + ulpi {
> + phy@a {
> + status = "okay";

Override by label (usb_hs1_phy). If the labels are named similarly, e.g.
usb_oth and usb_hs1_phy, then they will appear next to each other during
override/extend.

Best regards,
Krzysztof

\
 
 \ /
  Last update: 2022-11-27 22:09    [W:0.047 / U:0.592 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site