lkml.org 
[lkml]   [2022]   [Nov]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] irqchip: Allow test compilation of Broadcom drivers
From


On 11/26/2022 5:26 AM, Marc Zyngier wrote:
> On Mon, 24 Oct 2022 23:27:39 +0100,
> Florian Fainelli <f.fainelli@gmail.com> wrote:
>>
>> Allow test compilation of the Broadcom irqchip drivers by adding a
>> COMPILE_TEST dependency.
>>
>> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
>> ---
>> drivers/irqchip/Kconfig | 6 +++---
>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
>> index 7ef9f5e696d3..e4b2ec9b2450 100644
>> --- a/drivers/irqchip/Kconfig
>> +++ b/drivers/irqchip/Kconfig
>> @@ -116,7 +116,7 @@ config BCM6345_L1_IRQ
>>
>> config BCM7038_L1_IRQ
>> tristate "Broadcom STB 7038-style L1/L2 interrupt controller driver"
>> - depends on ARCH_BRCMSTB || BMIPS_GENERIC
>> + depends on ARCH_BRCMSTB || BMIPS_GENERIC || COMPILE_TEST
>
> Do we actually need all this churn now that OF is user-selectable (see
> 0166dc11be91)?

Seems to me that we would since that allows people to choose the
building of these drivers rather than lift the dependencies and replace
it with:

depends on OF

as this would prompt many users about drivers they do not care about.
--
Florian

\
 
 \ /
  Last update: 2022-11-27 21:29    [W:0.032 / U:1.388 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site