lkml.org 
[lkml]   [2022]   [Nov]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] hwmon: (hih6130) Modify mismatched function name
From
On 11/27/22 05:43, Jiapeng Chong wrote:
> No functional modification involved.
>
> drivers/hwmon/hih6130.c:185: warning: expecting prototype for hih6130_show_humidity(). Prototype was for hih6130_humidity_show() instead.
>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3264
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>

NACK. We don't start changing function names because some robot
thinks we should. Please do not submit such patches against the hwmon
or watchdog subsystems.

Guenter

> ---
> drivers/hwmon/hih6130.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hwmon/hih6130.c b/drivers/hwmon/hih6130.c
> index d9394e19fea8..764e6e185d98 100644
> --- a/drivers/hwmon/hih6130.c
> +++ b/drivers/hwmon/hih6130.c
> @@ -172,7 +172,7 @@ static ssize_t hih6130_temperature_show(struct device *dev,
> }
>
> /**
> - * hih6130_show_humidity() - show humidity measurement value in sysfs
> + * hih6130_humidity_show() - show humidity measurement value in sysfs
> * @dev: device
> * @attr: device attribute
> * @buf: sysfs buffer (PAGE_SIZE) where measurement values are written to

\
 
 \ /
  Last update: 2022-11-27 16:02    [W:0.029 / U:0.856 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site