Messages in this thread | | | Date | Sat, 26 Nov 2022 20:55:33 +0200 | Subject | Re: [PATCH v4 04/18] dt-bindings: msm: dsi-controller-main: Add compatible strings for every current SoC | From | Dmitry Baryshkov <> |
| |
On 25/11/2022 14:36, Bryan O'Donoghue wrote: > Currently we do not differentiate between the various users of the > qcom,mdss-dsi-ctrl. The driver is flexible enough to operate from one > compatible string but, the hardware does have some significant differences > in the number of clocks. > > To facilitate documenting the clocks add the following compatible strings > > - qcom,apq8064-dsi-ctrl > - qcom,msm8916-dsi-ctrl > - qcom,msm8974-dsi-ctrl > - qcom,msm8996-dsi-ctrl > - qcom,sc7180-dsi-ctrl > - qcom,sc7280-dsi-ctrl > - qcom,sdm630-dsi-ctrl > - qcom,sdm660-dsi-ctrl > - qcom,sdm845-dsi-ctrl > - qcom,sm8250-dsi-ctrl > > Each SoC dtsi should declare "qcom,socname-dsi-ctrl", "qcom,mdss-dsi-ctrl"; > > Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> > --- > .../display/msm/dsi-controller-main.yaml | 19 +++++++++++++++---- > 1 file changed, 15 insertions(+), 4 deletions(-) > > diff --git a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml > index 67d08dc338925..0cd2079137b02 100644 > --- a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml > +++ b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml > @@ -14,9 +14,20 @@ allOf: > > properties: > compatible: > - enum: > - - qcom,mdss-dsi-ctrl > - - qcom,qcm2290-dsi-ctrl > + items: > + - enum: > + - qcom,apq8064-dsi-ctrl > + - qcom,msm8916-dsi-ctrl > + - qcom,msm8974-dsi-ctrl > + - qcom,msm8996-dsi-ctrl > + - qcom,qcm2290-dsi-ctrl > + - qcom,sc7180-dsi-ctrl > + - qcom,sc7280-dsi-ctrl > + - qcom,sdm630-dsi-ctrl > + - qcom,sdm660-dsi-ctrl > + - qcom,sdm845-dsi-ctrl > + - qcom,sm8250-dsi-ctrl > + - const: qcom,mdss-dsi-ctrl > > reg: > maxItems: 1 > @@ -146,7 +157,7 @@ examples: > #include <dt-bindings/power/qcom-rpmpd.h> > > dsi@ae94000 { > - compatible = "qcom,mdss-dsi-ctrl"; > + compatible = "qcom,sc7180-dsi-ctrl", "qcom,mdss-dsi-ctrl";
Other examples (from qcom,SOC-mdss.yaml) also must be updated.
> reg = <0x0ae94000 0x400>; > reg-names = "dsi_ctrl"; >
-- With best wishes Dmitry
| |