Messages in this thread | | | From | Neil Armstrong <> | Date | Sat, 26 Nov 2022 17:03:39 +0100 | Subject | Re: [PATCH] arm64: dts: amlogic: align LED node names with dtschema |
| |
On Sat, 26 Nov 2022 at 15:24, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > On 26/11/2022 15:16, Krzysztof Kozlowski wrote: > > On 25/11/2022 18:16, Neil Armstrong wrote: > >> On 25/11/2022 15:41, Krzysztof Kozlowski wrote: > >>> The node names should be generic and DT schema expects certain pattern: > >>> > >>> amlogic/meson-sm1-bananapi-m5.dtb: leds: 'blue' does not match any of the regexes: '(^led-[0-9a-f]$|led)', 'pinctrl-[0-9]+' > >>> > >>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > >>> --- > >>> arch/arm64/boot/dts/amlogic/meson-sm1-bananapi-m5.dts | 4 ++-- > >>> 1 file changed, 2 insertions(+), 2 deletions(-) > >>> > >> > >> > >> <snip> > >> > >> > >> Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org> > > > > Aren't you maintainer of the platform? This means I should take care of > > this patch? > > Ah, this will be picked up by Kevin or Jerome? So this tag means only > Reviewer's statement of oversight, right?
Of course I'll pick it.
Neil
> > Best regards, > Krzysztof >
| |