| From | Martin Blumenstingl <> | Date | Sat, 26 Nov 2022 00:36:35 +0100 | Subject | Re: [PATCH 06/12] dt-bindings: rtc: convert rtc-meson.txt to dt-schema |
| |
Hi Neil,
On Fri, Nov 18, 2022 at 3:33 PM Neil Armstrong <neil.armstrong@linaro.org> wrote: > > Convert the Amlogic Meson6 RTC bindings to dt-schema. > > Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> With the comment below addressed please add my: Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
[...] > + mac@0 { > + reg = <0 6>; > + }; My understanding is that here you want to showcase the nvmem integration. This IP block only supports 4 bytes of NVMEM. Instead of using MAC (which is not what's stored here, the suspend firmware uses it instead) I'd just use something like: data@0 { reg = <0x0 4>; };
Best regards, Martin
|