Messages in this thread | | | Date | Fri, 25 Nov 2022 14:49:03 +0300 | From | Serge Semin <> | Subject | Re: [PATCH] NTB: ntb_tool: Add check for devm_kcalloc |
| |
On Tue, Nov 22, 2022 at 11:32:44AM +0800, Jiasheng Jiang wrote: > As the devm_kcalloc may return NULL pointer, > it should be better to add check for the return > value, as same as the others. > > Fixes: 7f46c8b3a552 ("NTB: ntb_tool: Add full multi-port NTB API support") > Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
Right. Thanks! Reviewed-by: Serge Semin <fancer.lancer@gmail.com>
-Sergey
> --- > drivers/ntb/test/ntb_tool.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/ntb/test/ntb_tool.c b/drivers/ntb/test/ntb_tool.c > index 5ee0afa621a9..eeeb4b1c97d2 100644 > --- a/drivers/ntb/test/ntb_tool.c > +++ b/drivers/ntb/test/ntb_tool.c > @@ -998,6 +998,8 @@ static int tool_init_mws(struct tool_ctx *tc) > tc->peers[pidx].outmws = > devm_kcalloc(&tc->ntb->dev, tc->peers[pidx].outmw_cnt, > sizeof(*tc->peers[pidx].outmws), GFP_KERNEL); > + if (tc->peers[pidx].outmws == NULL) > + return -ENOMEM; > > for (widx = 0; widx < tc->peers[pidx].outmw_cnt; widx++) { > tc->peers[pidx].outmws[widx].pidx = pidx; > -- > 2.25.1 > >
| |