Messages in this thread | | | Date | Fri, 25 Nov 2022 16:55:17 +0800 | From | Gao Xiang <> | Subject | Re: [External] [PATCH] erofs: check the uniqueness of fsid in shared domain in advance |
| |
Hi Tao,
On Fri, Nov 25, 2022 at 04:39:47PM +0800, Hou Tao wrote: > Hi, > > On 11/25/2022 4:25 PM, Jia Zhu wrote: > > Hi Tao, > > We've noticed this warning during development. It seems not a bug, so > > I ignored that. > > Many thanks for cacthing and clearing up the annoying warning. > Yes, it is not a bug. The duplicated mount will fail with -EEXIST even without > the patch. But it is a bit scary to see such warning in dmesg, so just fix it.
Thanks for the catch.
IMO, a WARN is indeed a bug, we cannot rely on this.
Overall the patch itself looks good to me as well, please help Cc LKML mailing list as well in v2...
Thanks, Gao Xiang
| |