Messages in this thread | | | Date | Thu, 24 Nov 2022 21:19:19 +0200 | From | Andy Shevchenko <> | Subject | Re: [PATCH] auxdisplay: hd44780: Fix potential memory leak in hd44780_remove() |
| |
On Wed, Sep 07, 2022 at 03:07:35PM +0800, Jianglei Nie wrote: > hd44780_probe() allocates a memory chunk for hd with kzalloc() and > makes "lcd->drvdata->hd44780" point to it. When we call hd44780_remove(), > we should release all relevant memory and resource. But "lcd->drvdata > ->hd44780" is not released, which will lead to a memory leak. > > We should release the "lcd->drvdata->hd44780" in hd44780_remove() to fix > the memory leak bug.
It's pity you haven't compiled your stuff, while the analysis seems valid to me.
What you need to do is: 1) compile on your side _before_ sending and be sure it compiles; 2) in this particular case you need an additional level of typing; 3) add Fixes tag; 4) resubmit as v2 the new version.
-- With Best Regards, Andy Shevchenko
| |