Messages in this thread | | | Date | Thu, 24 Nov 2022 19:06:21 +0200 | From | Andy Shevchenko <> | Subject | Re: [PATCH v3] x86/rtc: Remove __init for runtime functions |
| |
On Thu, Nov 24, 2022 at 05:57:30PM +0100, Matija Glavinic Pecotic wrote: > set_rtc_noop, get_rtc_noop are used runtime, therefore need init removed. > Crash was observed on x86 platform where cmos rtc is unused and disabled > via device tree. Function was triggered from ntp: sync_hw_clock, although > CONFIG_RTC_SYSTOHC=n, however sync_cmos_clock doesn't honour that. > > Workqueue: events_power_efficient sync_hw_clock > RIP: 0010:set_rtc_noop > Call Trace: > update_persistent_clock64 > sync_hw_clock > > Fix by dropping __init and making set/get_rtc_noop available runtime. > > Fixes: c311ed6183f4 ("x86/init: Allow DT configured systems to disable RTC at boot time") > Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Side note: seems you sent this not using `git send-email ...` (I see my @intel.com rather than @linux.intel.com in the Cc list).
But at least the Cc list looks closer to what MAINTAINERS says.
And you forgot to make it clear that a) it's a resend, by altering --subject-prefix, and b) mentioning this in the changelog.
-- With Best Regards, Andy Shevchenko
| |