Messages in this thread | | | Date | Thu, 24 Nov 2022 19:59:39 +0530 | From | Vignesh Raghavendra <> | Subject | Re: [PATCH 1/3] arm64: arch_k3: Removed ti mailbox and sci select |
| |
On 23/11/22 1:52 am, Nicolas Frayer wrote: > In order to build ti mailbox and ti sci as modules, > remove their automatic selection by ARCH_K3 >
$Subject: s/Removed/Remove, s/ti/TI s/sci/SCI
> Signed-off-by: Nicolas Frayer <nfrayer@baylibre.com> > --- > arch/arm64/Kconfig.platforms | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms > index 912529ac58b3..5f16eb498dbf 100644 > --- a/arch/arm64/Kconfig.platforms > +++ b/arch/arm64/Kconfig.platforms > @@ -126,8 +126,6 @@ config ARCH_K3 > select PM_GENERIC_DOMAINS if PM > select MAILBOX > select SOC_TI > - select TI_MESSAGE_MANAGER > - select TI_SCI_PROTOCOL > select TI_SCI_INTR_IRQCHIP > select TI_SCI_INTA_IRQCHIP > help
Why not use "imply" instead of "select". This should allow TI_SCI* drivers to be built as modules if required. Would make 2/3 and 3/3 redundant.
Also, note that 1/3, 2/3 and 3/3 have to go through 3 different trees, so not a great idea to post as a single series.
Regards Vignesh
| |