Messages in this thread | | | From | Ricardo Ribalda <> | Date | Thu, 24 Nov 2022 13:10:10 +0100 | Subject | Re: [PATCH v2 2/2] earlycon: Let users set the clock frequency |
| |
On Thu, 24 Nov 2022 at 12:19, Jiri Slaby <jirislaby@kernel.org> wrote: > > Hi, > > On 24. 11. 22, 11:02, Ricardo Ribalda wrote: > ... > > --- a/drivers/tty/serial/earlycon.c > > +++ b/drivers/tty/serial/earlycon.c > > @@ -120,9 +120,15 @@ static int __init parse_options(struct earlycon_device *device, char *options) > > } > > > > if (options) { > > + char *uartclk; > > + > > if (kstrtouint(options, 0, &device->baud) < 0) > > pr_warn("[%s] unsupported earlycon baud rate option\n", > > options); > > IMO this won't work if there is a comma in options (i.e. your new > clkrate param). kstrtouint will return -EINVAL in that case. > > > + uartclk = strchr(options, ','); > > + if (uartclk && kstrtouint(uartclk, 0, &port->uartclk) < 0) > > You are giving ",number" to kstrtouint, right? That won't work either ;).
The fun thing is that it worked because it fell back to the acpi parameters :). Will send a v3
Thanks! > > regards, > -- > js >
-- Ricardo Ribalda
| |