Messages in this thread | | | From | Miquel Raynal <> | Subject | Re: [PATCH] mtd: onenand: omap2: Drop obsolete dependency on COMPILE_TEST | Date | Thu, 24 Nov 2022 12:36:20 +0100 |
| |
On Tue, 2022-11-22 at 19:29:57 UTC, Jean Delvare wrote: > Since commit 0166dc11be91 ("of: make CONFIG_OF user selectable"), it > is possible to test-build any driver which depends on OF on any > architecture by explicitly selecting OF. Therefore depending on > COMPILE_TEST as an alternative is no longer needed. > > It is actually better to always build such drivers with OF enabled, > so that the test builds are closer to how each driver will actually be > built on its intended target. Building them without OF may not test > much as the compiler will optimize out potentially large parts of the > code. In the worst case, this could even pop false positive warnings. > Dropping COMPILE_TEST here improves the quality of our testing and > avoids wasting time on non-existent issues. > > Signed-off-by: Jean Delvare <jdelvare@suse.de> > Cc: Kyungmin Park <kyungmin.park@samsung.com> > Cc: Miquel Raynal <miquel.raynal@bootlin.com> > Cc: Richard Weinberger <richard@nod.at> > Cc: Vignesh Raghavendra <vigneshr@ti.com>
Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks.
Miquel
| |