Messages in this thread | | | From | "Quan, Evan" <> | Subject | RE: [PATCH] swsmu/amdgpu_smu: Fix the wrong if-condition | Date | Thu, 24 Nov 2022 10:10:22 +0000 |
| |
[AMD Official Use Only - General]
Reviewed-by: Evan Quan <evan.quan@amd.com>
> -----Original Message----- > From: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> On Behalf Of Yu > Songping > Sent: Thursday, November 24, 2022 9:53 AM > To: airlied@gmail.com; daniel@ffwll.ch > Cc: dri-devel@lists.freedesktop.org; amd-gfx@lists.freedesktop.org; linux- > kernel@vger.kernel.org > Subject: [PATCH] swsmu/amdgpu_smu: Fix the wrong if-condition > > The logical operator '&&' will make > smu->ppt_funcs->set_gfx_power_up_by_imu segment fault when > ppt_funcs is > smu->NULL. > > Signed-off-by: Yu Songping <yusongping@huawei.com> > --- > drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c > b/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c > index b880f4d7d67e..1cb728b0b7ee 100644 > --- a/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c > +++ b/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c > @@ -161,7 +161,7 @@ int smu_get_dpm_freq_range(struct smu_context > *smu, > > int smu_set_gfx_power_up_by_imu(struct smu_context *smu) { > - if (!smu->ppt_funcs && !smu->ppt_funcs- > >set_gfx_power_up_by_imu) > + if (!smu->ppt_funcs || !smu->ppt_funcs- > >set_gfx_power_up_by_imu) > return -EOPNOTSUPP; > > return smu->ppt_funcs->set_gfx_power_up_by_imu(smu); > -- > 2.17.1 [unhandled content-type:application/ms-tnef] | |