Messages in this thread | | | Date | Thu, 24 Nov 2022 10:59:54 +0100 | Subject | Re: [PATCH v2 3/4] irqchip: irq-mtk-cirq: Move register offsets to const array | From | AngeloGioacchino Del Regno <> |
| |
Il 23/11/22 17:28, Marc Zyngier ha scritto: > On Wed, 23 Nov 2022 14:57:02 +0000, > AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> wrote: >> >>>> + enum mtk_cirq_reg_index idx, >>>> + unsigned int cirq_num) >>> >>> What does cirq_num mean for registers that are not relative to an >>> interrupt? Create a separate helper for those. >>> >> Means literally nothing, so yes I agree, but... >> >> ... mtk_cirq_irq_reg(), mtk_cirq_reg() feels too similar and may lead to >> confusion while reading the code. >> >> Any advice about a possibly clear-er name? > > I think the names are OK. Passing an interrupt number as a parameter > is a good discriminant anyway. > > Please wait for a few days before posting the next version though. > > M. >
Let's go with these names then, thank you!
Regards, Angelo
| |