Messages in this thread | | | From | "Huang, Kai" <> | Subject | Re: [PATCH v7 15/20] x86/virt/tdx: Reserve TDX module global KeyID | Date | Thu, 24 Nov 2022 22:39:30 +0000 |
| |
On Wed, 2022-11-23 at 15:40 -0800, Dave Hansen wrote: > On 11/20/22 16:26, Kai Huang wrote: > > @@ -1053,6 +1056,12 @@ static int init_tdx_module(void) > > if (ret) > > goto out_free_tdmrs; > > > > + /* > > + * Reserve the first TDX KeyID as global KeyID to protect > > + * TDX module metadata. > > + */ > > + tdx_global_keyid = tdx_keyid_start; > > This doesn't "reserve" squat. > > You could argue that it "picks", "chooses", or "designates" the > 'tdx_global_keyid', but where is the "reservation"?
Right. I'll change to use "choose".
| |