Messages in this thread | | | Date | Wed, 23 Nov 2022 22:08:37 +0800 | Subject | Re: [PATCH V5 3/4] clk: meson: s4: add s4 SoC peripheral clock controller driver and bindings | From | Yu Tu <> |
| |
Hi Krzysztof,
On 2022/11/23 21:06, Krzysztof Kozlowski wrote: > [ EXTERNAL EMAIL ] > > On 23/11/2022 12:22, Yu Tu wrote: >> >> >> On 2022/11/23 18:09, Krzysztof Kozlowski wrote: >>> [ EXTERNAL EMAIL ] >>> >>> On 23/11/2022 03:13, Yu Tu wrote: >>>> Add the peripherals clock controller found and bindings in the s4 SoC family. >>>> >>>> Signed-off-by: Yu Tu <yu.tu@amlogic.com> >>>> --- >>>> .../clock/amlogic,s4-peripherals-clkc.yaml | 105 + >>> >>> No, this is total mess now. >>> >>> Additionally, you received a lot of feedback but your changelog says only: >>> "V3 -> V4: change format and clock flags." >>> so you ignored entire feedback? >>> >>> That's not the way to work with patches. >> >> Hi Krzysztof, >> You can check the previous email reply. Now I don't know who to follow >> your advice or Jerome's. I'm confused. Maybe you need to come to a >> conclusion. So I can change it in the next patch. > > I don't understand your comment. You received a lot of things to change > for your v3. You said here "change format and clock flagS", so all other > feedbacks from me were ignored? They were not contradicting to Jerome's > comments, so either you implement them and mention this in changelog, or > you keep discussing. >
I'm sorry I didn't write that clearly. The reality is that V4 I have changed some of the suggestions from Jerome. But there was a part that didn't agree before I sent V4, which Jerome chose to skip. Let's continue with V3, and then prepare this V5.
> Best regards, > Krzysztof > > .
| |