Messages in this thread | | | Date | Wed, 23 Nov 2022 08:26:47 -0500 | From | Steven Rostedt <> | Subject | Re: [PATCH] jump_label: use atomic_try_cmpxchg in static_key_slow_inc_cpuslocked |
| |
On Wed, 23 Nov 2022 10:08:59 +0100 Peter Zijlstra <peterz@infradead.org> wrote:
> On Tue, Nov 22, 2022 at 04:14:46PM -0500, Steven Rostedt wrote: > > > > + for (int v = atomic_read(&key->enabled); v > 0; ) > > > > Although it's permitted by the compiler, the kernel style is to not add > > declarations in conditionals. > > I'm thinking the whole motivation for upping to C99 was exactly so that > we could start using this pattern.
OK, if you are fine with it then sure. I personally like seeing all variables declared in one place. Maybe because I've been trained that way, and I can easily be confused when I see a variable somewhere and don't see it in the beginning declarations.
-- Steve
| |