lkml.org 
[lkml]   [2022]   [Nov]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.15 27/31] scsi: mpi3mr: Suppress command reply debug prints
    Date
    From: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>

    [ Upstream commit 7d21fcfb409500dc9b114567f0ef8d30b3190dee ]

    After it receives command reply, mpi3mr driver checks command result. If
    the result is not zero, it prints out command information. This debug
    information is confusing since they are printed even when the non-zero
    result is expected. "Power-on or device reset occurred" is printed for Test
    Unit Ready command at drive detection. Inquiry failure for unsupported VPD
    page header is also printed. They are harmless but look like failures.

    To avoid the confusion, print the command reply debug information only when
    the module parameter logging_level has value MPI3_DEBUG_SCSI_ERROR= 64, in
    same manner as mpt3sas driver.

    Signed-off-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
    Link: https://lore.kernel.org/r/20221111014449.1649968-1-shinichiro.kawasaki@wdc.com
    Reviewed-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
    Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/scsi/mpi3mr/mpi3mr_os.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    diff --git a/drivers/scsi/mpi3mr/mpi3mr_os.c b/drivers/scsi/mpi3mr/mpi3mr_os.c
    index b2c650542bac..a1deefcd2089 100644
    --- a/drivers/scsi/mpi3mr/mpi3mr_os.c
    +++ b/drivers/scsi/mpi3mr/mpi3mr_os.c
    @@ -2288,7 +2288,8 @@ void mpi3mr_process_op_reply_desc(struct mpi3mr_ioc *mrioc,
    }

    if (scmd->result != (DID_OK << 16) && (scmd->cmnd[0] != ATA_12) &&
    - (scmd->cmnd[0] != ATA_16)) {
    + (scmd->cmnd[0] != ATA_16) &&
    + mrioc->logging_level & MPI3_DEBUG_SCSI_ERROR) {
    ioc_info(mrioc, "%s :scmd->result 0x%x\n", __func__,
    scmd->result);
    scsi_print_command(scmd);
    --
    2.35.1
    \
     
     \ /
      Last update: 2022-11-23 13:50    [W:5.239 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site