Messages in this thread | | | From | Florian Weimer <> | Subject | Re: [PATCH v6 2/3] random: introduce generic vDSO getrandom() implementation | Date | Wed, 23 Nov 2022 11:48:06 +0100 |
| |
* Jason A. Donenfeld:
> static void *vgetrandom_alloc(size_t *num, size_t *size_per_each, unsigned int flags) > { > unsigned long ret = syscall(__NR_vgetrandom_alloc, num, size_per_each, flags); > return ret > -4096UL ? NULL : (void *)ret; > }
The traditional syscall function returns -1 on error and set errors, so using unsing long and the 4096 is quite misleading.
Thanks, Florian
| |