Messages in this thread | | | Date | Wed, 23 Nov 2022 11:20:02 +0100 | Subject | Re: [PATCH v1] soc: mediatek: mtk-pm-domains: Allow mt8186 ADSP default power on | From | Matthias Brugger <> |
| |
On 12/10/2022 09:54, Tinghan Shen wrote: > In the use case of configuring the access permissions of the ADSP core, > the mt8186 SoC ADSP power will be switched on in the bootloader because > the permission control registers are located in the ADSP subsys. > > Signed-off-by: Tinghan Shen <tinghan.shen@mediatek.com>
Do we need a fixes tag here? My bet is: Fixes: 88590cbc1703 ("soc: mediatek: pm-domains: Add support for mt8186")
Or is this not yet a problem but needed to be able to implement access permission configuration in the ADSP driver?
Regards, Matthias
> --- > drivers/soc/mediatek/mt8186-pm-domains.h | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/soc/mediatek/mt8186-pm-domains.h b/drivers/soc/mediatek/mt8186-pm-domains.h > index 108af61854a3..fce86f79c505 100644 > --- a/drivers/soc/mediatek/mt8186-pm-domains.h > +++ b/drivers/soc/mediatek/mt8186-pm-domains.h > @@ -304,7 +304,6 @@ static const struct scpsys_domain_data scpsys_domain_data_mt8186[] = { > .ctl_offs = 0x9FC, > .pwr_sta_offs = 0x16C, > .pwr_sta2nd_offs = 0x170, > - .caps = MTK_SCPD_KEEP_DEFAULT_OFF, > }, > [MT8186_POWER_DOMAIN_ADSP_INFRA] = { > .name = "adsp_infra", > @@ -312,7 +311,6 @@ static const struct scpsys_domain_data scpsys_domain_data_mt8186[] = { > .ctl_offs = 0x9F8, > .pwr_sta_offs = 0x16C, > .pwr_sta2nd_offs = 0x170, > - .caps = MTK_SCPD_KEEP_DEFAULT_OFF, > }, > [MT8186_POWER_DOMAIN_ADSP_TOP] = { > .name = "adsp_top", > @@ -332,7 +330,7 @@ static const struct scpsys_domain_data scpsys_domain_data_mt8186[] = { > MT8186_TOP_AXI_PROT_EN_3_CLR, > MT8186_TOP_AXI_PROT_EN_3_STA), > }, > - .caps = MTK_SCPD_SRAM_ISO | MTK_SCPD_KEEP_DEFAULT_OFF | MTK_SCPD_ACTIVE_WAKEUP, > + .caps = MTK_SCPD_SRAM_ISO | MTK_SCPD_ACTIVE_WAKEUP, > }, > }; >
| |