lkml.org 
[lkml]   [2022]   [Nov]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 07/11] blk-throttle: remove incorrect comment for tg_last_low_overflow_time
    Date
    Function tg_last_low_overflow_time is called with intermediate node as
    following:
    throtl_hierarchy_can_downgrade
    throtl_tg_can_downgrade
    tg_last_low_overflow_time

    throtl_hierarchy_can_upgrade
    throtl_tg_can_upgrade
    tg_last_low_overflow_time

    throtl_hierarchy_can_downgrade/throtl_hierarchy_can_upgrade will traverse
    from leaf node to sub-root node and pass traversed intermediate node
    to tg_last_low_overflow_time.

    No such limit could be found from context and implementation of
    tg_last_low_overflow_time, so remove this limit in comment.

    Signed-off-by: Kemeng Shi <shikemeng@huawei.com>
    ---
    block/blk-throttle.c | 1 -
    1 file changed, 1 deletion(-)

    diff --git a/block/blk-throttle.c b/block/blk-throttle.c
    index 0aa21832cb96..bd07f562c799 100644
    --- a/block/blk-throttle.c
    +++ b/block/blk-throttle.c
    @@ -1746,7 +1746,6 @@ static unsigned long __tg_last_low_overflow_time(struct throtl_grp *tg)
    return min(rtime, wtime);
    }

    -/* tg should not be an intermediate node */
    static unsigned long tg_last_low_overflow_time(struct throtl_grp *tg)
    {
    struct throtl_service_queue *parent_sq;
    --
    2.30.0
    \
     
     \ /
      Last update: 2022-11-23 07:07    [W:2.963 / U:0.648 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site