Messages in this thread | | | Date | Wed, 23 Nov 2022 11:08:31 +0100 | From | Tommaso Merciai <> | Subject | Re: [PATCH resend] media: staging: stkwebcam: Restore MEDIA_{USB,CAMERA}_SUPPORT dependencies |
| |
Hi Geert,
On Mon, Nov 21, 2022 at 04:58:33PM +0100, Geert Uytterhoeven wrote: > By moving support for the USB Syntek DC1125 Camera to staging, the > dependencies on MEDIA_USB_SUPPORT and MEDIA_CAMERA_SUPPORT were lost. > > Fixes: 56280c64ecacc971 ("media: stkwebcam: deprecate driver, move to staging")
Patch itself looks good but we have some style issue. Applying this patch I got the following warning from checkpatchl:
WARNING: Please use correct Fixes: style 'Fixes: <12 chars of sha1> ("<title line>")' - ie: 'Fixes: 56280c64ecac ("media: stkwebcam: deprecate driver, move to staging")' #10:
You have to pass only the first 12 chars of the sha1 commit into Fixes msg:
Use:
Fixes: 56280c64ecac ("media: stkwebcam: deprecate driver, move to staging")
Instead of:
Fixes: 56280c64ecacc971 ("media: stkwebcam: deprecate driver, move to staging")
Thanks & Regards, Tommaso
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > --- > drivers/staging/media/deprecated/stkwebcam/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/media/deprecated/stkwebcam/Kconfig b/drivers/staging/media/deprecated/stkwebcam/Kconfig > index 4450403dff41fb64..7234498e634ac61c 100644 > --- a/drivers/staging/media/deprecated/stkwebcam/Kconfig > +++ b/drivers/staging/media/deprecated/stkwebcam/Kconfig > @@ -2,7 +2,7 @@ > config VIDEO_STKWEBCAM > tristate "USB Syntek DC1125 Camera support (DEPRECATED)" > depends on VIDEO_DEV > - depends on USB > + depends on MEDIA_USB_SUPPORT && MEDIA_CAMERA_SUPPORT > help > Say Y here if you want to use this type of camera. > Supported devices are typically found in some Asus laptops, > -- > 2.25.1 >
-- Tommaso Merciai Embedded Linux Engineer tommaso.merciai@amarulasolutions.com __________________________________
Amarula Solutions SRL Via Le Canevare 30, 31100 Treviso, Veneto, IT T. +39 042 243 5310 info@amarulasolutions.com www.amarulasolutions.com
| |