lkml.org 
[lkml]   [2022]   [Nov]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 5/5] driver core: pass a const * into of_device_uevent()
On Tue, Nov 22, 2022 at 03:22:09PM -0600, Rob Herring wrote:
> On Mon, Nov 21, 2022 at 10:46:49AM +0100, Greg Kroah-Hartman wrote:
> > of_device_uevent() does not modify the struct device * passed into it,
> > so make it a const * to enforce this. Also the documentation for the
> > function was really wrong so fix that up at the same time.
> >
> > Cc: Rob Herring <robh+dt@kernel.org>
> > Cc: Frank Rowand <frowand.list@gmail.com>
> > Cc: devicetree@vger.kernel.org
> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > ---
> > drivers/of/device.c | 6 +++---
> > include/linux/of_device.h | 4 ++--
> > 2 files changed, 5 insertions(+), 5 deletions(-)
>
> Looks like I can take this one?

I need it for later patches I have coming that clean this up more.

But you can take it in your tree as well if you want to build on top of
it.

> The same could be done for several other functions in of/device.c.

That would be good!

thanks,

greg k-h

\
 
 \ /
  Last update: 2022-11-23 11:15    [W:0.113 / U:0.700 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site