Messages in this thread | | | Date | Wed, 23 Nov 2022 10:16:24 +0100 | From | Peter Zijlstra <> | Subject | Re: [RESEND PATCH 5/6] KVM: x86/VMX: add kvm_vmx_reinject_nmi_irq() for NMI/IRQ reinjection |
| |
On Tue, Nov 22, 2022 at 08:52:35PM +0000, Sean Christopherson wrote:
> Another wart that needs to be addressed is trace_kvm_exit(). IIRC, tracepoints > must be outside of noinstr, though maybe I'm misremembering that.
You are not, that is correct. Another point to be careful with is usage of jump_label and static_call, both can be used in noinstr *provided* they don't actually ever change -- so boot time setup only.
If either of them were to change, text_poke_bp() has a clue in the name.
| |