Messages in this thread Patch in this message | | | Date | Wed, 23 Nov 2022 17:06:19 +0800 (CST) | From | <> | Subject | [PATCH linux-next] powerpc/cell/axon msi: replace DEFINE SIMPLE ATTRIBUTE with
DEFINE DEBUGFS ATTRIBUTE |
| |
From: zhang songyi <zhang.songyi@zte.com.cn>
Fix the following coccicheck warning: /arch/powerpc/platforms/cell/axon_msi.c:457:0-23: WARNING: fops_msic should be defined with DEFINE_DEBUGFS_ATTRIBUTE
Signed-off-by: zhang songyi <zhang.songyi@zte.com.cn> --- arch/powerpc/platforms/cell/axon_msi.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/arch/powerpc/platforms/cell/axon_msi.c b/arch/powerpc/platforms/cell/axon_msi.c index 5b012abca773..ab080b5022ff 100644 --- a/arch/powerpc/platforms/cell/axon_msi.c +++ b/arch/powerpc/platforms/cell/axon_msi.c @@ -454,7 +454,7 @@ static int msic_get(void *data, u64 *val) return 0; }
-DEFINE_SIMPLE_ATTRIBUTE(fops_msic, msic_get, msic_set, "%llu\n"); +DEFINE_DEBUGFS_ATTRIBUTE(fops_msic, msic_get, msic_set, "%llu\n");
void axon_msi_debug_setup(struct device_node *dn, struct axon_msic *msic) { @@ -475,6 +475,7 @@ void axon_msi_debug_setup(struct device_node *dn, struct axon_msic *msic)
snprintf(name, sizeof(name), "msic_%d", of_node_to_nid(dn));
- debugfs_create_file(name, 0600, arch_debugfs_dir, msic, &fops_msic); + debugfs_create_file_unsafe(name, 0600, arch_debugfs_dir, + msic, &fops_msic); } #endif /* DEBUG */ -- 2.15.2
| |