Messages in this thread | | | Date | Thu, 24 Nov 2022 10:21:53 +0530 | Subject | Re: [PATCH] iommu/amd: Fix typo in macro parameter name | From | Vasant Hegde <> |
| |
HI Michael,
On 11/23/2022 3:48 AM, Michael Forney wrote: > IVRS_GET_SBDF_ID is only called with fn as the fourth parameter, > so this had no effect, but fixing the name will avoid bugs if that > ever changes.> > Signed-off-by: Michael Forney <mforney@mforney.org>
Thanks for finding and fixing this issue.
Reviewed-by: Vasant Hegde <vasant.hegde@amd.com>
-Vasant
> --- > drivers/iommu/amd/init.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iommu/amd/init.c b/drivers/iommu/amd/init.c > index 1a2d425bf568..099ca3ed7d73 100644 > --- a/drivers/iommu/amd/init.c > +++ b/drivers/iommu/amd/init.c > @@ -85,7 +85,7 @@ > > #define LOOP_TIMEOUT 2000000 > > -#define IVRS_GET_SBDF_ID(seg, bus, dev, fd) (((seg & 0xffff) << 16) | ((bus & 0xff) << 8) \ > +#define IVRS_GET_SBDF_ID(seg, bus, dev, fn) (((seg & 0xffff) << 16) | ((bus & 0xff) << 8) \ > | ((dev & 0x1f) << 3) | (fn & 0x7)) > > /*
| |