Messages in this thread | | | From | Kun-Fa Lin <> | Date | Thu, 24 Nov 2022 11:45:36 +0800 | Subject | Re: [PATCH v7 2/7] media: dt-binding: nuvoton: Add bindings for NPCM VCD and ECE engine |
| |
Hi Rob,
Thanks for the review.
> > +title: Nuvoton NPCM Video Capture/Encode Engine Device Tree Bindings > > Drop ' Device Tree Bindings' > > > + > > +maintainers: > > + - Joseph Liu <kwliu@nuvoton.com> > > + - Marvin Lin <kflin@nuvoton.com> > > + > > +description: | > > + Video Capture/Differentiation Engine (VCD) and Encoding Compression Engine > > + (ECE) present on Nuvoton NPCM SoCs. > > Sounds like 2 h/w blocks? If so, then it should be 2 separate nodes. > > > + > > +properties: > > + compatible: > > + enum: > > + - nuvoton,npcm750-video > > + - nuvoton,npcm845-video > > 'video' doesn't sound like the name of the h/w block(s).
VCD and ECE are 2 h/w blocks and our video capture driver needs to control their registers. If I separate them and store a phandle (referring to ece node) in vcd node like this:
vcd: vcd@f0810000 { compatible = "nuvoton,npcm750-vcd"; reg = <0xf0810000 0x10000>; ... nuvoton,enc-engine = <&ece>; };
ece: ece@f0820000 { compatible = "nuvoton,npcm750-ece"; reg = <0xf0820000 0x2000>; ... };
Does it look good to you?
Regards, Marvin
| |