Messages in this thread | | | From | Ian Rogers <> | Date | Wed, 23 Nov 2022 15:30:56 -0800 | Subject | Re: [PATCH 14/15] perf stat: Rename "aggregate-number" to "cpu-count" in JSON |
| |
On Wed, Nov 23, 2022 at 10:02 AM Namhyung Kim <namhyung@kernel.org> wrote: > > As the JSON output has been broken for a little while, I guess there are > not many users. Let's rename the field to more intuitive one. :)
I'm not sure cpu-count is accurate. For example, an uncore counter in a dual socket machine may have a CPU mask of "0, 36", ie one event per socket. The aggregate-number in this case I believe is 2.
Thanks, Ian
> Signed-off-by: Namhyung Kim <namhyung@kernel.org> > --- > tools/perf/util/stat-display.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/tools/perf/util/stat-display.c b/tools/perf/util/stat-display.c > index 43640115454c..7a39a1a7261d 100644 > --- a/tools/perf/util/stat-display.c > +++ b/tools/perf/util/stat-display.c > @@ -281,19 +281,19 @@ static void print_aggr_id_json(struct perf_stat_config *config, > > switch (config->aggr_mode) { > case AGGR_CORE: > - fprintf(output, "\"core\" : \"S%d-D%d-C%d\", \"aggregate-number\" : %d, ", > + fprintf(output, "\"core\" : \"S%d-D%d-C%d\", \"cpu-count\" : %d, ", > id.socket, id.die, id.core, nr); > break; > case AGGR_DIE: > - fprintf(output, "\"die\" : \"S%d-D%d\", \"aggregate-number\" : %d, ", > + fprintf(output, "\"die\" : \"S%d-D%d\", \"cpu-count\" : %d, ", > id.socket, id.die, nr); > break; > case AGGR_SOCKET: > - fprintf(output, "\"socket\" : \"S%d\", \"aggregate-number\" : %d, ", > + fprintf(output, "\"socket\" : \"S%d\", \"cpu-count\" : %d, ", > id.socket, nr); > break; > case AGGR_NODE: > - fprintf(output, "\"node\" : \"N%d\", \"aggregate-number\" : %d, ", > + fprintf(output, "\"node\" : \"N%d\", \"cpu-count\" : %d, ", > id.node, nr); > break; > case AGGR_NONE: > -- > 2.38.1.584.g0f3c55d4c2-goog >
| |