lkml.org 
[lkml]   [2022]   [Nov]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 11/15] perf stat: Do not pass runtime_stat to printout()
On Wed, Nov 23, 2022 at 10:02 AM Namhyung Kim <namhyung@kernel.org> wrote:
>
> It always passes a pointer to rt_stat as it's the only one. Let's not
> pass it and directly refer it in the printout().
>
> Signed-off-by: Namhyung Kim <namhyung@kernel.org>

Acked-by: Ian Rogers <irogers@google.com>

Thanks,
Ian

> ---
> tools/perf/util/stat-display.c | 9 ++++-----
> 1 file changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/tools/perf/util/stat-display.c b/tools/perf/util/stat-display.c
> index dd190f71e933..cdf4ca7f6e3a 100644
> --- a/tools/perf/util/stat-display.c
> +++ b/tools/perf/util/stat-display.c
> @@ -674,8 +674,7 @@ static bool is_mixed_hw_group(struct evsel *counter)
> }
>
> static void printout(struct perf_stat_config *config, struct outstate *os,
> - double uval, u64 run, u64 ena, double noise,
> - struct runtime_stat *st, int map_idx)
> + double uval, u64 run, u64 ena, double noise, int map_idx)
> {
> struct perf_stat_output_ctx out;
> print_metric_t pm;
> @@ -737,7 +736,7 @@ static void printout(struct perf_stat_config *config, struct outstate *os,
>
> if (ok) {
> perf_stat__print_shadow_stats(config, counter, uval, map_idx,
> - &out, &config->metric_events, st);
> + &out, &config->metric_events, &rt_stat);
> } else {
> pm(config, &os, /*color=*/NULL, /*format=*/NULL, /*unit=*/"", /*val=*/0);
> }
> @@ -834,7 +833,7 @@ static void print_counter_aggrdata(struct perf_stat_config *config,
>
> uval = val * counter->scale;
>
> - printout(config, &os, uval, run, ena, avg, &rt_stat, s);
> + printout(config, &os, uval, run, ena, avg, s);
>
> if (!metric_only)
> fputc('\n', output);
> @@ -987,7 +986,7 @@ static void print_no_aggr_metric(struct perf_stat_config *config,
> run = ps->aggr[counter_idx].counts.run;
>
> uval = val * counter->scale;
> - printout(config, &os, uval, run, ena, 1.0, &rt_stat, counter_idx);
> + printout(config, &os, uval, run, ena, 1.0, counter_idx);
> }
> if (!first)
> print_metric_end(config);
> --
> 2.38.1.584.g0f3c55d4c2-goog
>

\
 
 \ /
  Last update: 2022-11-24 00:28    [W:0.038 / U:0.360 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site