Messages in this thread | | | Date | Wed, 23 Nov 2022 14:27:51 -0800 | Subject | Re: [PATCH v8 08/13] x86/resctrl: Add sysfs interface to read mbm_total_bytes_config | From | Reinette Chatre <> |
| |
Hi Babu,
On 11/23/2022 10:35 AM, Moger, Babu wrote: > On 11/22/22 18:19, Reinette Chatre wrote: >> On 11/4/2022 1:00 PM, Babu Moger wrote:
...
>>> @@ -1521,6 +1593,12 @@ static struct rftype res_common_files[] = { >>> .seq_show = max_threshold_occ_show, >>> .fflags = RF_MON_INFO | RFTYPE_RES_CACHE, >>> }, >>> + { >>> + .name = "mbm_total_bytes_config", >>> + .mode = 0444, >>> + .kf_ops = &rdtgroup_kf_single_ops, >>> + .seq_show = mbm_total_bytes_config_show, >>> + }, >>> { >>> .name = "cpus", >>> .mode = 0644, >>> @@ -1627,6 +1705,15 @@ void __init thread_throttle_mode_init(void) >>> rft->fflags = RF_CTRL_INFO | RFTYPE_RES_MB; >>> } >>> >>> +void mbm_config_rftype_init(void) >> Does this need __init? > > Not. Required. Will remove it. >
Your response is not clear to me. I am not asking for any removal. My question is whether the function needs the __init attribute. That is, should this be:
void __init mbm_config_rftype_init(void)
Reinette
| |