lkml.org 
[lkml]   [2022]   [Nov]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v5] dt-bindings: iio: adc: ad7923: adjust documentation
On Wed, 23 Nov 2022 14:01:30 +0100
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote:

> On 23/11/2022 12:32, Edmund Berenson wrote:
> > On Wed, Nov 23, 2022 at 11:42:40AM +0100, Krzysztof Kozlowski wrote:
> >> On 22/11/2022 17:14, Edmund Berenson wrote:
> >>> - The ad7927 is fully compatible with ad7928 driver, add
> >>> documentation for device.
> >>> - ad7923 and ad7924 are treated the same in the driver, show
> >>> the relationship in the documentation.
> >>>
> >>> Suggested-by: Lukasz Zemla <Lukasz.Zemla@woodward.com>
> >>> Signed-off-by: Edmund Berenson <edmund.berenson@emlix.com>
> >>> ---
> >>> .../bindings/iio/adc/adi,ad7923.yaml | 26 ++++++++++++-------
> >>> 1 file changed, 17 insertions(+), 9 deletions(-)
> >>>
> >>
> >> 1. This is a v5, what are the changes?
> >>
> > The original idea was adding the compatible string into driver itself,
> > then it was suggested that I have a fallback compatible to 7928 as the
> > hardware versions are treated the same in the driver. After that it was
> > suggested to add deprecated flag to standalone compatibility, but doing
> > so I didn't want to add compatibility on driver side just to mark it
> > deprecated in the documentation, so I dropped driver side changes.
> > Finally I had some issues getting the documentation syntax into an
> > acceptable form, mainly const vs enum listing of compatibility stings.
>
> That's a bit too long for a changelog. Keep it short but still
> descriptive. Anyway - this must be in the changelog place, so after ---
>
>
> Best regards,
> Krzysztof
>

Given it won't get picked up by git anyway and all the info is in this thread
(plus we are right at end of the cycle and I want to pick this up).

Applied with Krzysztof's tag from v4.

Thanks,

Jonathan

\
 
 \ /
  Last update: 2022-11-23 21:16    [W:0.070 / U:0.276 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site